This repository has been archived by the owner. It is now read-only.
feat(highlights): Show more diverse highlights by limiting to one per domain #3398
Conversation
|
LGTM. just one tiny nit. r+ |
system-addon/lib/HighlightsFeed.jsm
Outdated
| } | ||
| // Request more than the expected length to allow for items being removed by | ||
| // deduping against Top Sites or multiple history from the same domain, etc. | ||
| const numItems = HIGHLIGHTS_MAX_LENGTH * 5 + TOP_SITES_SHOWMORE_LENGTH; |
rlr
Sep 9, 2017
Contributor
no need to do this math on every fetch #nano-optimization
no need to do this math on every fetch #nano-optimization
Mardak
Sep 9, 2017
Author
Member
Moved to top as MANY_EXTRA_LENGTH
Moved to top as MANY_EXTRA_LENGTH
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fix #3390. r?@rlr Did some refactoring / clean up too.
Before (team):
After (only aaron):
