Skip to content
This repository has been archived by the owner. It is now read-only.

/ activity-stream Archived

feat(styles): Convert the info panel into an door hanger with arrow #3644

Merged
merged 3 commits into from Oct 4, 2017
Merged

feat(styles): Convert the info panel into an door hanger with arrow #3644

merged 3 commits into from Oct 4, 2017

Conversation

@Mardak
Copy link
Member

@Mardak Mardak commented Oct 4, 2017

r?@rlr I split this into 3 commits:

  1. fix #3634 spacing
  2. switch to aliased grey-90 opacities
  3. fix #3631 arrow stuff

Screenshots:
screen shot 2017-10-03 at 5 04 07 pm

Linux:
screen shot 2017-10-03 at 5 28 32 pm

Invisible sizing:
screen shot 2017-10-03 at 4 52 50 pm

RTL:
screen shot 2017-10-03 at 4 52 35 pm
@Mardak Mardak requested a review from rlr Oct 4, 2017
@Mardak Mardak force-pushed the Mardak:gh3631-arrow branch from d081450 to 0484d95 Oct 4, 2017
@rlr
rlr approved these changes Oct 4, 2017
View changes
Copy link
Contributor

@rlr rlr left a comment

WFM. I'll have to rebase and fix #3617 after this lands.
@rlr rlr assigned Mardak and unassigned rlr Oct 4, 2017
Mardak added 3 commits Oct 4, 2017
@Mardak
fix(styles): Increase section spacing to avoid overlapping meatball m…
ab2ba9c 
…enu icon (#3644)
@Mardak
chore(styles): Use official photon grey-90 opacities and alias them (#…
51ffd78 
…3644)
@Mardak
feat(styles): Convert the info panel into a door hanger with arrow (#…
f13b481 
…3644)
@Mardak Mardak force-pushed the Mardak:gh3631-arrow branch from 0484d95 to f13b481 Oct 4, 2017
@Mardak Mardak merged commit 1bb681a into mozilla:master Oct 4, 2017
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Mardak added a commit that referenced this pull request Oct 4, 2017
@Mardak
fix(styles): Increase section spacing to avoid overlapping meatball m…
826b0d6 
…enu icon (#3644)
Mardak added a commit that referenced this pull request Oct 4, 2017
@Mardak
chore(styles): Use official photon grey-90 opacities and alias them (#…
a8660dc 
…3644)
@Mardak Mardak deleted the Mardak:gh3631-arrow branch Oct 4, 2017
@as-pine-proxy
Copy link
Collaborator

@as-pine-proxy as-pine-proxy commented Oct 4, 2017

Treeherder: d4c6fc69e2c5e6ccfeca5fbbcc867385c6e8afd9
@Mardak Mardak mentioned this pull request Nov 3, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rlr rlr

Assignees

@Mardak Mardak

Labels
PR / R+ pushed-to-pine
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

The Tiles context menu button "(...)" slightly overlaps the Section info symbol "(?)" on Windows
Invisible space for info prevents clicking on Edit
3 participants
@Mardak @as-pine-proxy @rlr