New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(styles): Convert the info panel into an door hanger with arrow #3644

Merged
merged 3 commits into from Oct 4, 2017

Conversation

Projects
None yet
3 participants
@Mardak
Member

Mardak commented Oct 4, 2017

r?@rlr I split this into 3 commits:

  1. fix #3634 spacing
  2. switch to aliased grey-90 opacities
  3. fix #3631 arrow stuff

Screenshots:
screen shot 2017-10-03 at 5 04 07 pm

Linux:
screen shot 2017-10-03 at 5 28 32 pm

Invisible sizing:
screen shot 2017-10-03 at 4 52 50 pm

RTL:
screen shot 2017-10-03 at 4 52 35 pm

@Mardak Mardak requested a review from rlr Oct 4, 2017

@rlr

rlr approved these changes Oct 4, 2017

WFM. I'll have to rebase and fix #3617 after this lands.

@rlr rlr assigned Mardak and unassigned rlr Oct 4, 2017

@rlr rlr added PR / R+ and removed PR / Needs review labels Oct 4, 2017

@Mardak Mardak merged commit 1bb681a into mozilla:master Oct 4, 2017

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

Mardak added a commit that referenced this pull request Oct 4, 2017

@Mardak Mardak deleted the Mardak:gh3631-arrow branch Oct 4, 2017

@as-pine-proxy

This comment has been minimized.

Show comment
Hide comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment