This repository has been archived by the owner. It is now read-only.
Fix Bug 1449338 - Show currently selected engine in newtabs search input #4097
Conversation
|
Testing with the patch from bug 1449338 applied with default and dark theme: And for comparison before: |
| @@ -2,11 +2,7 @@ | |||
| $search-height: 35px; | |||
| $search-input-left-label-width: 35px; | |||
Mardak
Apr 18, 2018
Member
This should be renamed to something referring to icon. And is the sizing still correct given that the icon size is increasing from 16px to 18px? Perhaps we want something like
$search-icon-size: 18px;
$search-icon-padding: 8px;
$search-icon-width: 2 * $search-icon-padding + $search-icon-size;
This should be renamed to something referring to icon. And is the sizing still correct given that the icon size is increasing from 16px to 18px? Perhaps we want something like
$search-icon-size: 18px;
$search-icon-padding: 8px;
$search-icon-width: 2 * $search-icon-padding + $search-icon-size;
|
Thanks for the review, updated and used the new vars in their appropriate places, looks cleaner now too, cheers |
|
Was about to land this but then remembered rtl! |
| @@ -16,13 +15,15 @@ | |||
| width: 100%; | |||
|
|
|||
| input { | |||
| background: var(--newtab-textbox-background-color); | |||
| background: var(--newtab-textbox-background-color) var(--newtab-search-icon) $search-icon-padding center / $search-icon-size no-repeat; | |||
Mardak
Apr 19, 2018
Member
Oh oops! Almost forgot that the icon was centered before in the label, but now this is anchored to the left offset by $padding. For rtl, we'll want to offset from the right with the 2-value form: background-position-x: right $search-icon-padding;
Oh oops! Almost forgot that the icon was centered before in the label, but now this is anchored to the left offset by $padding. For rtl, we'll want to offset from the right with the 2-value form: background-position-x: right $search-icon-padding;
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This updates the CSS to handle the change in https://reviewboard.mozilla.org/r/237204/diff/#index_header