This repository has been archived by the owner. It is now read-only.
Fix Bug 1432595 - Add section in prefs to turn off parts of Highlights #4111
Conversation
|
Yup this looks good. Thanks! |
… what gets shown Fix Bug 1432595 - Add section in prefs to turn off parts of Highlights
| @@ -102,6 +102,9 @@ prefs_topstories_description2=Great content from around the web, personalized fo | |||
| prefs_topstories_options_sponsored_label=Sponsored Stories | |||
| prefs_topstories_sponsored_learn_more=Learn more | |||
| prefs_highlights_description=A selection of sites that you’ve saved or visited | |||
| prefs_highlights_options_visited_label=Visited Pages | |||
| prefs_highlights_options_download_label=Most Recent Download | |||
flodolo
Jun 15, 2018
Collaborator
Question from a localizer: should this be downloads (plural)?
Question from a localizer: should this be downloads (plural)?
Mardak
Jun 22, 2018
Author
Member
This is singular as it shows only one download
This is singular as it shows only one download
TonnesM
Jun 22, 2018
Yeah, I noticed by testing meanwhile but thanks for the reminder. ;)
Side note: we used l10n for "Most recently downloaded" which a) covers both singular and plural (at least for my locale), and b) circumvents the use of "download" as a noun. Note that some locales (de, es) currently do use translations for "downloads" (noun, plural).
Yeah, I noticed by testing meanwhile but thanks for the reminder. ;)
Side note: we used l10n for "Most recently downloaded" which a) covers both singular and plural (at least for my locale), and b) circumvents the use of "download" as a noun. Note that some locales (de, es) currently do use translations for "downloads" (noun, plural).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This should probably land after #4076 but doesn't really need to. The patches don't actually conflict because the other PR adds "includeDownloads" in a non-conflicting area.
r? @sarracini This doesn't have the logic where if everything is unchecked, Highlights should get unchecked... for a followup!