Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1520890 - Spocs need to use v1 personaliation at the least #4864

Merged
merged 1 commit into from Apr 9, 2019

Conversation

@ScottDowne
Copy link
Collaborator

commented Mar 22, 2019

No description provided.

@ScottDowne ScottDowne force-pushed the ScottDowne:t-1520890 branch from 5a99a06 to d72b3e8 Mar 22, 2019

@ScottDowne ScottDowne requested review from k88hudson and gvn Mar 22, 2019

@gvn

This comment has been minimized.

Copy link
Collaborator

commented Mar 25, 2019

Are there any steps that I should follow to test this? Or any particular points that you'd like me to focus on?

@ScottDowne ScottDowne force-pushed the ScottDowne:t-1520890 branch from b2c4a41 to 7469e15 Apr 2, 2019

@ScottDowne

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 4, 2019

Steps to test: (I'm still working on them)

  1. Create a brand new profile.
  2. Visit all these sites...

http://softpedia.com
http://speedtest.net
http://chip.de
http://cultofmac.com
http://majorgeeks.com
http://9to5mac.com
http://tomshardware.com
http://xda-developers.com
http://sourceforge.net
http://pcmag.com
http://techradar.com
http://tomsguide.com
http://cloudwards.net
http://softwarehow.com
http://macworld.com
http://trusted.de
http://howtogeek.com
http://spiceworkds.com
http://carbonite.com
http://actifio.com
http://asigra.com
http://software.dell.com
http://evault.com
http://falconstor.com
http://intronis.com
http://netapp.com
http://unitrends.com
http://veeam.com
http://veritas.com

  1. Close all those tabs, it's a mess, and restart the browser. You need to keep doing this until it reloads with none of those tabs opening. I find I have to let the tab load before closing it, or it comes back. It wrecks havoc on the console, which makes it pretty impossible to do some of the next steps. Or if you can clear your console after reloading, you're also probably fine.
  2. Go to about:config
  3. Change this pref: browser.newtabpage.activity-stream.asrouter.devtoolsEnabled to true
  4. Change this pref: browser.newtabpage.activity-stream.discoverystream.endpoints to http,file
  5. Change this pref: browser.newtabpage.activity-stream.discoverystream.config to {"api_key_pref":"extensions.pocket.oAuthConsumerKey","enabled":true,"show_spocs":true,"personalized":true,"layout_endpoint":"https://gist.githubusercontent.com/ScottDowne/fd3a8ef725efab4f5b4d1bb9292827cb/raw/e468d7aa37b5af9affbacc3831a0a15835d24efa/p-v1-layout"}
  6. Enter this into the global browser console (not the console for the single page) Services.obs.notifyObservers(null, "idle-daily");
  7. Restart the browser again.
  8. Open about:newtab#devtools-ds
  9. Scroll to the bottom of that page until you see a spoc in "spoc data" with the id 36296 (there should be only one spoc)
  10. Open it up.
  11. Look for score and item_score in the data, they should be different. score should be higher. I'm getting "item_score": 0.2036, "score": 0.992036
@gvn

This comment has been minimized.

Copy link
Collaborator

commented Apr 8, 2019

Confirmed repro steps on a local build. 👍

@gvn

gvn approved these changes Apr 8, 2019

Copy link
Collaborator

left a comment

Code looks solid to me!

@ScottDowne ScottDowne force-pushed the ScottDowne:t-1520890 branch from 3d6e45a to a93b84f Apr 9, 2019

@ScottDowne ScottDowne merged commit c896fe5 into mozilla:master Apr 9, 2019

2 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.