Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1541359 - Chore: Increase our frontend code coverage #4883

Merged
merged 3 commits into from Apr 8, 2019

Conversation

@piatra
Copy link
Collaborator

commented Apr 4, 2019

After:
image
Added unit tests to bump our coverage to where the report is mostly green/gray making it easier to spot issues when trying to land new code.
ASRouterAdmin has a threshold set to 0 so adding new code there won't require any tests (that's the only one showing up in red).

@piatra piatra requested review from ScottDowne and gvn Apr 4, 2019

@k88hudson k88hudson added PR / R+ and removed PR / Needs review labels Apr 8, 2019

@k88hudson k88hudson assigned piatra and unassigned ScottDowne and gvn Apr 8, 2019

@piatra piatra merged commit 778db3d into mozilla:master Apr 8, 2019

2 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.