Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Bug 1531933 – Use proper image sizes #4885
That went together fairly fast!
First thing I noticed (unless I missed it) you probably need something similar to this:
I pulled that from our impression code, so probably want to adapt it a bit.
Also I'm still looking at your pr
If I open a new tab using the
I know when me and Nan were working on the Impressions stuff, we had to use a bit of care with the visibility stuff.
Locally I removed the
I wonder if we should sanity check this with Nick Chapman?
Finally, I think you need to go through the array in