Skip to content
This repository has been archived by the owner on Jan 19, 2022. It is now read-only.

to display only device name #26

Merged
merged 1 commit into from
Feb 3, 2016

Conversation

dadaa
Copy link

@dadaa dadaa commented Feb 3, 2016

Hello,
The reason of this pull request is that some devices may not be able to use "Firefox OS" brand.
Could you consider this?

@jryans
Copy link
Contributor

jryans commented Feb 3, 2016

Is there any additional data from getprop or other shell commands that can be used to identify "not Firefox OS" devices?

Many of the model names for existing phones are inscrutable strings like "LD1231", so for Firefox OS branded devices, it helps to include those words as it does currently.

@autonome
Copy link

autonome commented Feb 3, 2016

Most devices that developers are using will not be branded Firefox OS - eg, our Flames and Z3Cs.

B2G is likely to be more often correct if you absolutely must use a general-case string there.

@jryans
Copy link
Contributor

jryans commented Feb 3, 2016

Actually, I just checked my Z3C, and it already includes (B2G) in the name, so you end up with Firefox OS (Xperia Z3 Compact (B2G)).

Okay, I think I am convinced. Let's move forward with this. Thanks for the change!

jryans added a commit that referenced this pull request Feb 3, 2016
Remove Firefox OS from device name
@jryans jryans merged commit cf976f3 into mozilla:master Feb 3, 2016
@jryans
Copy link
Contributor

jryans commented Feb 3, 2016

@dadaa, do you need a new version of the add-on to be released with this change?

@dadaa
Copy link
Author

dadaa commented Feb 4, 2016

@jryans Thank you very much!
Yes, I want to use that!

@jryans
Copy link
Contributor

jryans commented Feb 4, 2016

@dadaa Okay, I've released 0.8.7 with this change. It may take up to 24 hours before the update appears in Firefox.

@dadaa
Copy link
Author

dadaa commented Feb 5, 2016

@jryans Thank you! I could confirm the change!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants