This repository has been archived by the owner on Jan 19, 2022. It is now read-only.
Bug 1395741 - migrate from sdk-loader to devtools loader;r=ochameau #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jryans
reviewed
Sep 7, 2017
bootstrap.js
Outdated
| return Cu.import("resource://devtools/shared/base-loader.js", {}); | ||
| } catch (e) { | ||
| // Firefox 56 and older, use the addon-sdk loader. | ||
| return Cu.import('resource://gre/modules/commonjs/toolkit/loader.js').Loader; |
There was a problem hiding this comment.
Nit: Use " (The old version was wrong too...)
There was a problem hiding this comment.
Good catch, thanks!
bootstrap.js
Outdated
| unload = loaderModule.unload; | ||
|
|
||
| let loaderOptions = { | ||
| paths: { | ||
| "./": uri, | ||
| "": "resource://gre/modules/commonjs/" | ||
| // Remove when Firefox 56 is no longer supported. | ||
| "": "resource://gre/modules/commonjs/", |
There was a problem hiding this comment.
Hmm, isn't this for using SDK modules only? Aren't they already removed? I would think this bit can already be removed...?
There was a problem hiding this comment.
Actually we still have a module.exports = require("sdk/event/core"); for backward compatibility.
But I will move the resource:// prefix to this require, it will be easier to get rid of pre FF57 code this way.
juliandescottes
force-pushed
the
nosdk-loader
branch
3 times, most recently
from
d2272d0
to
f5e55e1
Compare
juliandescottes
force-pushed
the
nosdk-loader
branch
from
f5e55e1
to
f434c09
Compare
|
For the record, I retested after fixing the first batch of review comments. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have tested this both with the latest central and with an older Nightly that didn't have
resource://devtools/shared/base-loader.jsIn both cases I could see my android runtime and connect to it.