Bug 885457 - Display browser console instead of error console. #10

Merged
merged 1 commit into from Jun 24, 2013

Conversation

Projects
None yet
2 participants
@Mossop

View changes

lib/addons-builder-helper.js
@@ -21,6 +22,18 @@ const CONFIG_PREF = "extensions.addonBuilderHelper.trustedOrigins";
* Return `message` attribute sent back to the webpage.
*/
function toggleConsoleWindow(command) {
+ // Starting with FF 25, we should be displaying the browser console

This comment has been minimized.

Show comment Hide comment
@Mossop

Mossop Jun 20, 2013

Member

Looks like we're actually doing it from Firefox 24

@Mossop

Mossop Jun 20, 2013

Member

Looks like we're actually doing it from Firefox 24

+ // and HUDConsoleUI only exposes toggle.
+ if (command == "open") {
+ let browserWindow = windowManager.getMostRecentWindow('navigator:browser');
+ browserWindow.HUDConsoleUI.toggleBrowserConsole();

This comment has been minimized.

Show comment Hide comment
@Mossop

Mossop Jun 20, 2013

Member

Is there a possibility of no browser window being open here, like on OSX?

@Mossop

Mossop Jun 20, 2013

Member

Is there a possibility of no browser window being open here, like on OSX?

This comment has been minimized.

Show comment Hide comment
@ochameau

ochameau Jun 20, 2013

Member

You are right, but that would be really uncommon to be on Addon builder website and do not have any browser window opened ;-)
Having said that, I'm not against adding an if.

@ochameau

ochameau Jun 20, 2013

Member

You are right, but that would be really uncommon to be on Addon builder website and do not have any browser window opened ;-)
Having said that, I'm not against adding an if.

This comment has been minimized.

Show comment Hide comment
@Mossop

Mossop Jun 20, 2013

Member

Oh yeah if this is triggered from the webpage then we can probably safely assume that.

@Mossop

Mossop Jun 20, 2013

Member

Oh yeah if this is triggered from the webpage then we can probably safely assume that.

ochameau added a commit that referenced this pull request Jun 24, 2013

Merge pull request #10 from ochameau/browserconsole
Bug 885457 - Display browser console instead of error console. r=@Mossop

@ochameau ochameau merged commit a713cb7 into mozilla:master Jun 24, 2013

@ochameau ochameau deleted the ochameau:browserconsole branch Jun 24, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment