This repository has been archived by the owner on Feb 26, 2022. It is now read-only.
simple-prefs #270
Merged
simple-prefs #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: python-lib/cuddlefish/__init__.py python-lib/cuddlefish/xpi.py
…o be used to set defaults still)
… it should, and does not when it should not.
- adding tests for int and string types
…s a good place to be raising errors..)
…prefs - adding argument for simple-pref listeners, which is the name of the pref that was changed
|
a problem here is that the strings in options.xul are not being localized.. |
| @@ -48,6 +48,12 @@ called `package.json`. This file is also referred to as the | |||
| [`icon64URL` entry in the Install Manifest](https://developer.mozilla.org/en/install_manifests#icon64URL), | |||
| so the icon should be 64x64 pixels in size. | |||
|
|
|||
| * `preferences` - a JSON object whose keys are preference names, where each | |||
| key is has a JSON object that has the following optional keys `type`, `value`, | |||
|
One more thing: make sure to label this API as |
still need to implement changes in the package spec though..
- test update: simple prefs test extension now reflects changes to the docs
…kaging works as documented
|
@mykmelez ok I think I have made all of the changes that you requested. |
|
Yup, looks good, r=myk. |
mykmelez
added a commit
that referenced
this pull request
Nov 28, 2011
fix bug 645207 - implement high-level preferences API
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For more info see #187