This repository has been archived by the owner on Feb 26, 2022. It is now read-only.
Bug 644595 - Implement very minimal support of add-on page API. #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| const { WindowTracker, isBrowser } = require('api-utils/window-utils'); | ||
| const { add, remove } = require('api-utils/array'); | ||
| const { getTabs, closeTab } = require('api-utils/tabs/utils'); | ||
| const { when: unload } = require('api-utils/unload'); |
There was a problem hiding this comment.
unload and remove aren't used. It may be related, wouldn't you aiming to clean inContentWhileList on addon unload?
There was a problem hiding this comment.
Right, I though I had to cleanup my tabs at unload, but it looks like WindowTracker will call onUntrack for each window on add-on unload. Which is counterintuitive to me, but yeah it's fine for now. I'll remove these dependencies.
|
r+ Works fine! |
Gozala
added a commit
that referenced
this pull request
Feb 12, 2012
Bug 644595 - Implement very minimal support of add-on page API. r=@ochameau
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be a first draft implementation that we will be able to refine in later cycles. This change implements module
addon-page. When it's loadedrequire('self').data.url('index.html')tabs will have no chrome. In a future it should be unnecessary to dorequire('addon-page'), also this won't be limited to one page only.