Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Bug 708190: Apply page-mod on existing documents. #404
Here is random comments that can be usefull for review:
I'm waiting for feedback about the public API before writing docs.
To summarize I'm ok with this change once naming issue is resolved
Feel free to decide if you want to address other comments or ask for another review if you desire. Otherwise r+ by with
@Gozala, I followed the trend by using more code from tab/utils, but I had to simplify it a bit.
Otherwise, the naming issue is quite tough, no one came up with ideal name that makes sense without conflict.
Ideally we would use
In https://github.com/mozilla/addon-sdk/wiki/JEP-Content-scripts you tend to suggest this