Bug 682681 tab.title should never be empty #492

Merged
merged 5 commits into from Jul 24, 2012

Conversation

Projects
None yet
3 participants
Contributor

erikvold commented Jul 13, 2012

update to #236

@Gozala Gozala and 1 other commented on an outdated diff Jul 13, 2012

packages/api-utils/lib/tabs/tab.js
@@ -101,8 +101,8 @@ const TabTrait = Trait.compose(EventEmitter, {
* Changing this property changes an actual title.
* @type {String}
*/
- get title() this._contentDocument.title,
- set title(value) this._contentDocument.title = String(value),
+ get title() this._contentDocument.title || this._tab.label,
+ set title(value) this._tab.label = String(value),
@Gozala

Gozala Jul 13, 2012

Member

Could you please add getTabTitle(tab) function to tab/utils and use that from here ?

P.S.: tab is actual tab node not trait or something alike.

@erikvold

erikvold Jul 14, 2012

Contributor

k got it

Gozala merged commit 3ac1e78 into mozilla:master Jul 24, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment