Skip to content

Added an OSX example to the cfx tool reference page #504

Closed
wants to merge 1 commit into from

4 participants

@ghost
ghost commented Jul 21, 2012

Added an OSX example to the cfx tool reference page

@KWierso
Mozilla member
KWierso commented Jul 21, 2012

@wbamberg
Will, you want to take a look at this?

@wbamberg
wbamberg commented Aug 3, 2012

Sorry, no ideas. But I see there's a bug for this raised now: https://bugzilla.mozilla.org/show_bug.cgi?id=779221. Maybe if you could address the other comments, we'll pull this in without using config, and can always update it to use a config when that but gets fixed?

@wbamberg wbamberg was assigned Dec 13, 2012
@KWierso
Mozilla member
KWierso commented Jan 3, 2013

@wbamberg Do you want to take over this?

@ochameau
Mozilla member

I think that's fine to expose such usage. I didn't knew about local.json before reading this pull request.
So you can easily use cfx with tons of arguments like that when using shell scripts.
It also show how to reuse an existing firefox profile.

The only thing that scares me is the size of this page, which is already huuuuge!
Do we still support cfx develop? I have the feeling that I killed that feature..

@wbamberg

Something weird happened with this PR. I think my original comment on it was that it's not very good practice to encourage people to use such huge commands, and it would be better to use local.json for this example. Then I found that this example does not actually work with local.json, and bug 779221 was raised as a consequence.

Personally, I don't see this addition to the docs as being terribly valuable, it's not that obvious what extra it is telling people over what's already there, especially as this page is so big already. What might be useful would be a note on things like "how to find your profile" - but there are links to that sort of information already. Or to have more examples along with the documentation for each command?

I didn't knew about local.json before reading this pull request.

But that's already documented: https://addons.mozilla.org/en-US/developers/docs/sdk/1.12/dev-guide/cfx-tool.html#Using%20Configurations.

Do we still support cfx develop? I have the feeling that I killed that feature..

I think you might have done, yes.

The only thing that scares me is the size of this page, which is already huuuuge!

I agree about this. Having a table of contents would help, and I've been meaning to add ToCs for all pages for a while (I tried to do this ages ago but didn't like the result, but it's time to try again). But splitting this page up into a guide of its own would be better I think (one page for each supported command, one page for internal commands, once for each of the guide-y things at the end of the page).

So I think I'd vote to:

  • close this PR
  • open 2 bugs, one to split the cfx page and one to add ToCs to all pages.
@erikvold

The docs are on mdn now, and anyone can update them :)

@erikvold erikvold closed this Sep 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.