GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
This takes over where pull request 461 left off. It fell behind and then I screwed up the branch it was on, so it was easier to just make a new pull request than clean up what was there.
This changes init.py to use the preflight.create_jid() to generate the jid, and fixes the test so it knows about the jid being in package.json from the start.
I had to change what initializer() returns to include both the status code (1 or 0) and the jid, as I couldn't think of any other way to pass the randomly generated jid into the test for it to use. If you can think of a better way, feel free to suggest it.
Bug 613587 - Generate jid as part of cfx run/xpi
Fix things to get the test working correctly
Don't need to import sys into the test
It might be cool to print it last, before Your sample add-on is now ready.
Just to emphasis it and may be drop a note to say that's in package.json:id attribute and that you can set a human readable one?
Your sample add-on is now ready
@KWierso is this still relevant ? Do you plan on finishing this ?
If no please close this pull request, thanks!
Yeah. Just need to find some time to get it landable, and possibly address @ochameau's comment.
Closing this in favor of #703 because I'm not sure how I messed up the branch this was working from, and it's easier to start from scratch in a new branch than to clean this one up for committing...