Bug 795490 #594

Merged
merged 1 commit into from Dec 22, 2012

Conversation

Projects
None yet
3 participants
@canuckistani
Contributor

canuckistani commented Sep 29, 2012

A pull request with Brian's suggested patch from https://bugzilla.mozilla.org/show_bug.cgi?id=795490

I've tested this, seems to work fine

@ghost ghost assigned Gozala Sep 29, 2012

packages/addon-kit/lib/panel.js
@@ -354,6 +354,7 @@ const Panel = Symbiont.resolve({
},
_onChange: function _onChange(e) {
+ this._frameLoadersSwapped = false;

This comment has been minimized.

@erikvold

erikvold Oct 4, 2012

Contributor

this should be in the if statement to match byran's diff, but I'm not sure this is the best way to go yet anyhow.

@erikvold

erikvold Oct 4, 2012

Contributor

this should be in the if statement to match byran's diff, but I'm not sure this is the best way to go yet anyhow.

@canuckistani

This comment has been minimized.

Show comment
Hide comment
@canuckistani

canuckistani Dec 14, 2012

Contributor

@Gozala @erikvold as discussed today in triage, I updated this pull request for merge.

Contributor

canuckistani commented Dec 14, 2012

@Gozala @erikvold as discussed today in triage, I updated this pull request for merge.

@Gozala

This comment has been minimized.

Show comment
Hide comment
@Gozala

Gozala Dec 14, 2012

Member

I'm working on getting tree back to green, I'd love to defer landing this until tree is green.

Member

Gozala commented Dec 14, 2012

I'm working on getting tree back to green, I'd love to defer landing this until tree is green.

@canuckistani

This comment has been minimized.

Show comment
Hide comment
@canuckistani

canuckistani Dec 17, 2012

Contributor

Sounds good to me!

Contributor

canuckistani commented Dec 17, 2012

Sounds good to me!

Gozala added a commit that referenced this pull request Dec 22, 2012

@Gozala Gozala merged commit 41d3fd8 into mozilla:master Dec 22, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment