Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Bug 795490 #594

Merged
merged 1 commit into from over 1 year ago

3 participants

Jeff Griffiths Irakli Gozalishvili Erik Vold
Jeff Griffiths
Collaborator

A pull request with Brian's suggested patch from https://bugzilla.mozilla.org/show_bug.cgi?id=795490

I've tested this, seems to work fine

packages/addon-kit/lib/panel.js
... ...
@@ -354,6 +354,7 @@ const Panel = Symbiont.resolve({
354 354
   },
355 355
 
356 356
   _onChange: function _onChange(e) {
  357
+    this._frameLoadersSwapped = false;
1
Erik Vold Collaborator
erikvold added a note October 04, 2012

this should be in the if statement to match byran's diff, but I'm not sure this is the best way to go yet anyhow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Jeff Griffiths
Collaborator

@Gozala @erikvold as discussed today in triage, I updated this pull request for merge.

Irakli Gozalishvili
Collaborator

I'm working on getting tree back to green, I'd love to defer landing this until tree is green.

Jeff Griffiths
Collaborator

Sounds good to me!

Irakli Gozalishvili Gozala merged commit 41d3fd8 into from December 21, 2012
Irakli Gozalishvili Gozala closed this December 21, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 1 author.

Dec 13, 2012
Jeff Griffiths fix for bug #795490 - panel.contentURL change doesn't swap out the vi…
…sible page in a panel
16bc7b1
This page is out of date. Refresh to see the latest.

Showing 1 changed file with 1 addition and 0 deletions. Show diff stats Hide diff stats

  1. 1  lib/sdk/panel.js
1  lib/sdk/panel.js
@@ -354,6 +354,7 @@ const Panel = Symbiont.resolve({
354 354
   },
355 355
 
356 356
   _onChange: function _onChange(e) {
  357
+    this._frameLoadersSwapped = false;
357 358
     if ('contentURL' in e && this._frame) {
358 359
       // Cleanup the worker before injecting the content script in the new
359 360
       // document
Commit_comment_tip

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.