Skip to content


Subversion checkout URL

You can clone with
Download ZIP


Bug 803417 - Fix support for packages with defined dependencie #627

wants to merge 1 commit into from

2 participants


@wbamberg pointed out that our documentation is no longer valid

It turns out cfx breaks on packages that declare dependencies on "addon-kit" or "api-utils" as such packages no longer exist and there for can't be found. This patch replaces these dependencies with
"addon-sdk" instead.

Either way I think we should change documentation to avoid people start depending on features that don't plan on supporting.

@Gozala Gozala Pretend that everything depends on "addon-sdk" and
nothing depends on "addon-kit" or "api-utils".
@erikvold erikvold was assigned

I get the following error:

(addon-sdk)server:amo-addon-tester erikvold$ cfx run
Traceback (most recent call last):
  File "/Users/erikvold/github/addon-sdk/bin/cfx", line 33, in <module>
  File "/Users/erikvold/github/addon-sdk/python-lib/cuddlefish/", line 650, in run
    pkg_cfg = packaging.build_config(env_root, target_cfg, options.packagepath)
  File "/Users/erikvold/github/addon-sdk/python-lib/cuddlefish/", line 260, in build_config
    pkgconfig = get_config_in_dir(path)
  File "/Users/erikvold/github/addon-sdk/python-lib/cuddlefish/", line 220, in get_config_in_dir
AttributeError: 'dict' object has no attribute 'append'

can you post package.json for the addon you cfx run ?

@Gozala Gozala closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Oct 23, 2012
  1. @Gozala

    Pretend that everything depends on "addon-sdk" and

    Gozala authored
    nothing depends on "addon-kit" or "api-utils".
This page is out of date. Refresh to see the latest.
Showing with 6 additions and 0 deletions.
  1. +6 −0 python-lib/cuddlefish/
6 python-lib/cuddlefish/
@@ -215,6 +215,12 @@ def get_config_in_dir(path):
base_json.root_dir = path
+ if "dependencies" in base_json:
+ deps = base_json["dependencies"]
+ deps.append("addon-sdk")
+ deps = [x for x in deps if x not in ["addon-kit", "api-utils"]]
+ base_json["dependencies"] = deps
return base_json
def _is_same_file(a, b):
Something went wrong with that request. Please try again.