Skip to content

Bug 803417 - Fix support for packages with defined dependencie #627

Closed
wants to merge 1 commit into from

2 participants

@Gozala
Mozilla member
Gozala commented Oct 23, 2012

@wbamberg pointed out that our documentation is no longer valid
https://addons.mozilla.org/en-US/developers/docs/sdk/latest/dev-guide/tutorials/adding-menus.html

It turns out cfx breaks on packages that declare dependencies on "addon-kit" or "api-utils" as such packages no longer exist and there for can't be found. This patch replaces these dependencies with
"addon-sdk" instead.

Either way I think we should change documentation to avoid people start depending on features that don't plan on supporting.

@Gozala Gozala Pretend that everything depends on "addon-sdk" and
nothing depends on "addon-kit" or "api-utils".
5d045a0
@erikvold erikvold was assigned Oct 24, 2012
@erikvold

I get the following error:

(addon-sdk)server:amo-addon-tester erikvold$ cfx run
Traceback (most recent call last):
  File "/Users/erikvold/github/addon-sdk/bin/cfx", line 33, in <module>
    cuddlefish.run()
  File "/Users/erikvold/github/addon-sdk/python-lib/cuddlefish/__init__.py", line 650, in run
    pkg_cfg = packaging.build_config(env_root, target_cfg, options.packagepath)
  File "/Users/erikvold/github/addon-sdk/python-lib/cuddlefish/packaging.py", line 260, in build_config
    pkgconfig = get_config_in_dir(path)
  File "/Users/erikvold/github/addon-sdk/python-lib/cuddlefish/packaging.py", line 220, in get_config_in_dir
    deps.append("addon-sdk")
AttributeError: 'dict' object has no attribute 'append'
@Gozala
Mozilla member
Gozala commented Oct 29, 2012

can you post package.json for the addon you cfx run ?

@Gozala Gozala closed this Nov 26, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.