Bug 804935 - TypeError: window.tabs is undefined #630

Merged
merged 1 commit into from Jan 3, 2013

Projects

None yet

3 participants

@ZER0
Contributor
ZER0 commented Oct 24, 2012

It was a regression during fennec implementation of windows and tabs. A ChromeWindow was used instead of the expected BrowserWindow.

@ZER0 ZER0 Bug 804935 - TypeError: window.tabs is undefined
It was a regression during fennec implementation of windows and tabs. A `ChromeWindow` was used instead of the expected `BrowserWindow`.
08e9d03
Contributor

Tried this on mobile? I'm not sure it will work.

Contributor

Well I'm not sure why this doesn't break a test on Fennec, it should. In tabs/tab-fennec.js a ChromeWindow is expected, and with this path a browser window will be passed through.

Contributor
ZER0 commented Nov 14, 2012

As I said in the comment, the line I get it back is pretty useless, I just put it for consistency. As soon as I requires the windows module, everything works. My feeling is that there is some tracker that take trace of all the windows / tabs somehow. You probably knows that better than me, because you ported on Fennec. If you have any clue about that, just let me know!

It's definitely odd, and we should investigate more, but this is just to remove the regression and put back the behavior like it was before.

Member
KWierso commented Jan 3, 2013

@erikvold Want to review this?

@erikvold erikvold merged commit f2c93bd into mozilla:master Jan 3, 2013
@KWierso KWierso added a commit that referenced this pull request Jan 4, 2013
@KWierso KWierso Back out Merge pull request #630 from ZER0/window.tabs/bug804935 for …
…causing debug failures.

This reverts commit f2c93bd, reversing
changes made to b205f22.
532a51a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment