Bug 783743 - addon-page should work with "index.html?…" & "index.html#…" #639

Merged
merged 1 commit into from Dec 13, 2012

3 participants

@ZER0

Replaced usage of inContentWhitelist with hideChromeForLocation to have more flexibility about URLs to hide.

@ZER0 ZER0 Bug 783743 - addon-page should work with "index.html?[stuff]" and "in…
…dex.html#[stuff]" (and both together)

- Replaced usage of `inContentWhitelist` with `hideChromeForLocation` to have more flexibility about URLs to hide
b6e04ca
@Gozala
Mozilla member

I sort of was not comfortable with an idea of overriding window method itself. Maybe it's fine but probably @Mossop knows it better. Also I guess I'm fine with doing this as long as we also have a patch for FF to change hideChromeForLocation such that this hack won't be necessary. Maybe whitelist could contain regexps or functions ?

@ZER0

@Gozala as I wrote in the comment, this is what in MDN is suggested for hiding browser chrome. However I totally understand your uncomfortable feeling, because I had the same. Even if this is what is suggested, it feels an hack to me as well and error prone in some cases. I'm totally in to improve Firefox's hideChromeForLocation / whitelist behavior.

@Mossop
Mozilla member

I'm ok with it as long as we're still calling the old function and are properly cleaning up on unload, looks like both of those are happening so looks good. Let's get a Firefox bug filed to make this better though.

@Gozala Gozala merged commit da55fc6 into mozilla:master Dec 13, 2012
@Mossop
Mozilla member

I guess I was wrong, this isn't cleaning up after itself properly. Filed https://bugzilla.mozilla.org/show_bug.cgi?id=829845

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment