Integration of cfx-js into master #644

Closed
wants to merge 30 commits into
from

Conversation

Projects
None yet
4 participants
Member

Gozala commented Nov 1, 2012

Thread where we can discuss cfx-js integration.

ochameau and others added some commits Jun 20, 2012

@ochameau ochameau Introduce cfx.js and use it to build the xpi before launching firefox…
…/adb.
a1f0782
@ochameau ochameau Fix cfx on MacOS 32bit. e2f67a6
@ochameau ochameau Fix broken tests. d4cc4c1
@ochameau ochameau Use dash-separated attribute names. e9acc5a
@ochameau ochameau Address review comments. e07cea5
@ochameau ochameau Add comment. 5986bc2
@ochameau ochameau Improve README readability. 18ebf6e
@ochameau ochameau Address review comments about preferences. 05a45ce
@ochameau ochameau Address review comment. 678f380
@ochameau ochameau Address review comments: Comments about nsICommandLineHandler, use is…
…Primitive, use camel case.
8f076e3
@ochameau ochameau Avoid adding attributes to `harnessOptions` that should not end up in…
… harness-options.json. And pass SDK and Addon path to JS.
f60e165
@ochameau ochameau Update docs. e1b3a11
@ochameau ochameau Fix preferences support and ensure generating same options.xul file f…
…or the same data against python implementation.
b6df90f
@ochameau ochameau Avoid generating different serialization for the same data in harness…
…-options.json (compared to python impl.)
1b38645
@ochameau ochameau Address review comment. f2373f5
@ochameau ochameau Add related bugs number in comments. adc5eff
@ochameau ochameau Merge branch 'master' into cfx.js bbeb385
@ochameau ochameau Merge branch 'master' into cfx.js 0182a85
@ochameau ochameau Improved cfx README with big picture and more internal details. d258c41
@ochameau ochameau Fix cfx xpi test. r=me 76ee4cf
@Gozala Gozala Merge branch 'master' into cfx-js
Conflicts:
	lib/sdk/test/tmp-file.js
	python-lib/cuddlefish/rdf.py
58d51d5
@Gozala Gozala Merge with master. df496b2
@Gozala Gozala Merge pull request #643 from Gozala/cfx-js
Integrating cfx-js work a=@gozala
4d968b6
Member

Gozala commented Nov 1, 2012

@ochameau let's keep discussion here.

Member

Gozala commented Nov 1, 2012

We need to integrate my changes from #578 into this.

Member

Gozala commented Nov 1, 2012

Created new pull request #645 to target cfx-js branch instead.

Member

Gozala commented Nov 1, 2012

@ochameau the problem I'm having with this is the tests fail:

Using binary at '/Applications/Firefox.app/Contents/MacOS/firefox-bin'.
Using profile at '/var/folders/0z/nztt5n4d4kg7b43dg9nv_3fc0000gp/T/tmp9pKVKO.mozrunner'.
Running tests on Firefox 15.0/Gecko 15.0 ({ec8030f7-c20a-464f-9b0e-13a3a9e97384}) under darwin/x86.
error: cfx-js: TEST FAILED: test-xpi.testIt (exception)
error: cfx-js: An exception occurred.
Traceback (most recent call last):
  File "resource://cfx-at-jetpack/addon-sdk/lib/sdk/timers.js", line 31, in notify
    callback.apply(null, args);
  File "resource://cfx-at-jetpack/addon-sdk/lib/sdk/test/runner.js", line 65, in null
    onDone: onDone
  File "resource://cfx-at-jetpack/addon-sdk/lib/sdk/test/harness.js", line 317, in runTests
    nextIteration();
  File "resource://cfx-at-jetpack/addon-sdk/lib/sdk/test/harness.js", line 244, in nextIteration
    findAndRunTests(loader, nextIteration);
  File "resource://cfx-at-jetpack/addon-sdk/lib/sdk/test/runner.js", line 109, in findAndRunTests
    onDone: nextIteration
  File "resource://cfx-at-jetpack/addon-sdk/lib/sdk/deprecated/unit-test.js", line 24, in findAndRunTests
    function (tests) {
  File "resource://cfx-at-jetpack/addon-sdk/lib/sdk/deprecated/unit-test-finder.js", line 69, in findTests
    cb(tests);
  File "resource://cfx-at-jetpack/addon-sdk/lib/sdk/deprecated/unit-test.js", line 27, in null
    onDone: options.onDone});
  File "resource://cfx-at-jetpack/addon-sdk/lib/sdk/deprecated/unit-test.js", line 424, in startMany
    runNextTest(this);
  File "resource://cfx-at-jetpack/addon-sdk/lib/sdk/deprecated/unit-test.js", line 419, in runNextTest
    self.start({test: test, onDone: runNextTest});
  File "resource://cfx-at-jetpack/addon-sdk/lib/sdk/deprecated/unit-test.js", line 444, in start
    this.test.testFunction(this);
  File "resource://cfx-at-jetpack/cfx-js/tests/test-xpi.js", line 65, in null
    writeFile(file.join(section, "test.js"), rootJsFile);
  File "resource://cfx-at-jetpack/cfx-js/tests/test-xpi.js", line 57, in writeFile
    let testFile = file.open(path, "w");
  File "resource://cfx-at-jetpack/addon-sdk/lib/sdk/io/file.js", line 147, in open
    stream.init(file, openFlags, permFlags, 0);
[Exception... "Component returned failure code: 0x80520015 (NS_ERROR_FILE_ACCESS_DENIED) [nsIFileOutputStream.init]"  nsresult: "0x80520015 (NS_ERROR_FILE_ACCESS_DENIED)"  location: "JS frame :: resource:///modules/XPIProvider.jsm -> jar:file:///var/folders/0z/nztt5n4d4kg7b43dg9nv_3fc0000gp/T/tmp9pKVKO.mozrunner/extensions/cfx@jetpack.xpi!/bootstrap.js -> resource://cfx-at-jetpack/addon-sdk/lib/toolkit/loader.js -> resource://cfx-at-jetpack/addon-sdk/lib/sdk/io/file.js :: open :: line 147"  data: no]
Member

Gozala commented Nov 1, 2012

I could probably ignore it for the time being, assuming that's some problem with temp-file API.

Contributor

ZER0 commented Nov 6, 2012

I tested on MacBook Pro on OS X 10.7.4, and I got the same exception of @Gozala

erikvold was assigned Nov 17, 2012

Member

Gozala commented Jul 25, 2013

Closing this can be reopened once it's ready.

Gozala closed this Jul 25, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment