Bug 834958 - pwpb update selection module to ignore private windows #814

Closed
wants to merge 24 commits into
from

Conversation

Projects
None yet
2 participants
@ZER0
Contributor

ZER0 commented Feb 26, 2013

Only the last commit is relevant here, the rest are from #769

erikvold and others added some commits Feb 5, 2013

bug 834961: window/utils openDialog method no longer returns a privat…
…e window if pb is not supported, now private-browsing tests are broken for pwpb builds..
bug 834961 adding a test of the activeWindow and activeBrowserWindow …
…properties of the window-utils module in pb supported mode
bug 834961: created onFocus in window/utils module using it in tests,…
… and testing activeWindow setter on window-utils module
Merge branch 'master' of git://github.com/mozilla/addon-sdk into 834961
Conflicts:
	lib/sdk/private-browsing.js
	lib/sdk/private-browsing/utils.js
	test/private-browsing/helper.js
	test/private-browsing/windows.js
	test/test-private-browsing.js
bug 834961: no longer prevent opening of private windows in window/ut…
…ils, it is prevented in high level windows module still however. Also fixing issues using the loader in test/private-browsing/helper
@erikvold

This comment has been minimized.

Show comment Hide comment
@erikvold

erikvold Mar 4, 2013

Contributor

Hey @ZER0 can you please rebase this when you have a chance?

Contributor

erikvold commented Mar 4, 2013

Hey @ZER0 can you please rebase this when you have a chance?

@erikvold

This comment has been minimized.

Show comment Hide comment
@erikvold

erikvold Jun 24, 2013

Contributor

We can close this one I think, correect me if I am wrong.

Contributor

erikvold commented Jun 24, 2013

We can close this one I think, correect me if I am wrong.

@erikvold erikvold closed this Jun 24, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment