Bug 841766 - We should warn users when magical require is used #822

Merged
merged 1 commit into from Jun 7, 2013

Projects

None yet

3 participants

@ochameau
Mozilla member

https://bugzilla.mozilla.org/show_bug.cgi?id=841766

Still a work in progress as I haven't found how to avoid these deprecation message in layout-change and require test addons that are explicitely using old require paths to ensure that the mapping works...

@Gozala
Mozilla member

I think I'm ok with landing this as is even though we'll have some warning in tests and figure how to remove them in the followup change.

@ochameau ochameau merged commit 66098bc into mozilla:master Jun 7, 2013
@ochameau ochameau deleted the ochameau:deprecate-mapping branch Jun 7, 2013
@KWierso KWierso added a commit that referenced this pull request Jun 7, 2013
@KWierso KWierso Revert "Merge pull request #822 from ochameau/deprecate-mapping" for …
…ModuleNotFoundError

This reverts commit 66098bc, reversing
changes made to 2bdf0b9.
f457b21
@KWierso
Mozilla member

I had to revert this because it was unable to find the sdk/xul-app module and was throwing errors on all platforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment