Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Bug 846169: Display a message that tbpl will recognise for test timeouts when in parseable output mode. #824

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Member

Mossop commented Mar 1, 2013

The tricky bit is getting the name of the running test but that is output into the log in a standard form so I'm using a regex to track it. Only the parseable output that tbpl uses is affected here.

@@ -714,6 +725,10 @@ def maybe_remove_outfile():
last_output_time = time.time()
sys.stderr.write(new_chars)
sys.stderr.flush()
+ if is_running_tests:
@Mossop

Mossop Mar 1, 2013

Member

I guess I should check if parseable it True here too.

+ sys.stderr.write("TEST-UNEXPECTED-FAIL | %s | %s\n" % (test_name, message))
+ sys.stderr.flush()
+ return Exception(message)
+
@ochameau

ochameau Mar 1, 2013

Member

nit: I'd prefer Timeout to not depend on scope variable and accept parseable and test-name parameters.

@Mossop Mossop closed this Jul 8, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment