Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Bug 839746 - global private windows (Fx <=19) are not ignored #888

Merged
merged 1 commit into from Mar 22, 2013

Conversation

Projects
None yet
4 participants
Member

Gozala commented Mar 22, 2013

This pull request is based of already reviewed #881 and only thing it does addresses issues that @ochameau has pointed out.

Member

ochameau commented Mar 22, 2013

Copy paste what I said in PR #882:
ok: function(v) !v || v instanceof require("./panel").Panel would have fix the issue without introducing a workaround that is hard to understand. (this.panel.show(getNodeView.implement({}, function() domNode));)
We shouldn't forget we are landing for 1.14 which is at risk and we should aim to land minimal changes now.
method isn't on stabilization yet, so pulling this will pull changeset that introduced method and eventual dependencies.

Member

Gozala commented Mar 22, 2013

Copy paste what I said in PR #882:
ok: function(v) !v || v instanceof require("./panel").Panel would have fix the issue without introducing a workaround that is hard to understand. (this.panel.show(getNodeView.implement({}, function() domNode));)
We shouldn't forget we are landing for 1.14 which is at risk and we should aim to land minimal changes now.
method isn't on stabilization yet, so pulling this will pull changeset that introduced method and eventual dependencies.

The whole point of that pull request was not to import panel cause otherwise it breaks widget since requiring panel throws.

Contributor

ZER0 commented Mar 22, 2013

r+, not convinced totally about getNodeView but it's not a big deal.

Member

Gozala commented Mar 22, 2013

r+, not convinced totally about getNodeView but it's not a big deal.

To be clear you mean name right ?

@Gozala Gozala added a commit that referenced this pull request Mar 22, 2013

@Gozala Gozala Merge pull request #888 from Gozala/bug/indipendent-panel@839746
Bug 839746 - global private windows (Fx <=19) are not ignored r=@ZER0
eed3c68

@Gozala Gozala merged commit eed3c68 into mozilla:master Mar 22, 2013

Member

Gozala commented Mar 22, 2013

@KWierso So this is basically a change that needs uplift as far as I understand. I'll be landing followup change that removes workaround, but we should not uplift that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment