Missing icon in about:addons

[pdehaan]

After installing temp addon in Firefox Nightly, I see the following in my about:addons page:

[pdehaan]

Ah, my local [generated] install.rdf looks like this, which may explain why I'm seeing missing name/icon:

    <em:name></em:name>
    <em:description>template shield study to serve a as base.  This one is about Toolbar Buttons</em:description>
    <em:creator>Gregg Lind &lt;glind@mozilla.com&gt;</em:creator>
    <em:iconURL>chrome://whiterose-experience-icons/content/icon.png</em:iconURL>

Note that I don't seem to have a "whiterose-experience-icons" directory anywhere, so that may be the cause of missing assets.

[pdehaan]

The <em:name> is blank because it's copying strings from package.json:

https://github.com/gregglind/addon-wr/blob/526535ea04ce79f59a79381ab71b8c9be61b9af8/package.json#L6-L18

https://github.com/gregglind/addon-wr/blob/526535ea04ce79f59a79381ab71b8c9be61b9af8/templates/install.rdf.mustache#L11

Note that the addon{} object doesn't contain a name property. Not sure if we can make it more generic name so it copies the package.json name.

[gregglind]

Ah! yes, that is a foo that I fixed other places. I will fix that.

[gregglind]

I solved name, but forgot icon. Will just rip it out probably!

[gregglind]

Okay with this, as a wontfix.