Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Audit trigger words #19
Comments
|
I've corrected the "disintegration" word in the list with my latest PR. My understanding from @gregglind is that we will receive a list of words from our partners, so these are just a temporary list for now; that said, we can trivially change this as you suggest if needed. |
|
These are coming in a soon patch. |
|
Closing. Latest strings are in #23 PR. |
pdehaan
closed this
Dec 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
pdehaan commentedDec 7, 2017
https://github.com/gregglind/addon-wr/blob/16aff7d830938d7c115ae31ade288b1b49155f3c/addon/webextension/background.js#L11
I don’t think “disintigration” is a word. http://www.dictionary.com/misspelling?term=disintigration (me thinks we want “disintegration”, possibly).
Do we want to use "army"? It seems like that could get weird if it's an article about a real live army event on a news site and we inject some styling and tooltips.
Not sure if instead of a string+regex we just do an array of words like this, which gives us a bit more flexibility: