Audit APPLICABLE_PROTOCOLS #20

Closed
pdehaan opened this Issue Dec 7, 2017 · 4 comments

Comments

Projects
None yet
3 participants
Contributor

pdehaan commented Dec 7, 2017

https://github.com/gregglind/addon-wr/blob/16aff7d830938d7c115ae31ade288b1b49155f3c/addon/webextension/background.js#L141

We were discussing earlier today on Vidyo, but just confirming that we 💯 want to modify ftp: and file: protocols.

Collaborator

biancadanforth commented Dec 8, 2017

@pdehaan , do you mean remove them from the list? Can you elaborate?

Contributor

pdehaan commented Dec 8, 2017

@biancadanforth Basically I was just looking for confirmation that we wanted to modify files from ftp:// and file:// protocols and limit this to just /https?/.

Member

gregglind commented Dec 8, 2017

File yes. That's how we do local testing.
Ftp: I have no idea of how users can / would even open ftp links! I think it's safe enough, but if we want to remove it, I have no objection.

Contributor

pdehaan commented Dec 8, 2017

Ref: #23 PR.

@gregglind gregglind closed this in 94bbd66 Dec 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment