discussing parts of the persistent page effect, re #1 #3

Closed
gregglind opened this Issue Dec 5, 2017 · 2 comments

Comments

Projects
None yet
2 participants
Member

gregglind commented Dec 5, 2017

When effect happens

  • 1. IF NOT EMBEDDED, the effect happens all the time.
  • 2. IF EMBEDDED, the effect only happens IFF the pref is turned on.

What effect is.

  • 1. for specific list of words (bundled with addon)
  • 2. on first occurance ONLY in session
  • 3. make them 'upside down' (transform: scaleY(-1)) see https://codepen.io/BJack/pen/sGmop

Suggested design:

  • background-script.js => keeps the list of words, and the 'already seen' list.

  • content-script.js, use http://benalman.com/code/projects/jquery-replacetext/examples/replacetext/ to sub in <span=wr-modified> or such around the affected words

  • communication between content and background:

    • should I do this at all? (or maybe... tell me if any words are available to modify?)
    • if yes, what words are still 'available'
    • if I saw any words, there they are, tell background those words are blacked out.
Member

gregglind commented Dec 5, 2017

Collaborator

biancadanforth commented Dec 5, 2017

Note: The replaceText library does not do recursive searching of the HTML doc.

biancadanforth added a commit that referenced this issue Dec 12, 2017

Merge pull request #32 from gregglind/v102-launch
1.0.2, minor word list changes.  Fix #31 Fix #28 Fix #22 Fix #3 Fix #1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment