Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add title to review entry, update styles #1526

Closed
kumar303 opened this issue Dec 22, 2016 · 4 comments · Fixed by #1706
Closed

Add title to review entry, update styles #1526

kumar303 opened this issue Dec 22, 2016 · 4 comments · Fixed by #1706

Comments

@kumar303
Copy link
Contributor

The review entry form has changed a bit in the latest Sketch file. We need to bring the style up to date and also add title entry which wasn't there before.

Here is the mock but check the Sketch file for the latest:

screenshot 2016-12-22 15 10 00

@vcarciu
Copy link

vcarciu commented Feb 9, 2017

With keyboard open, the scroll should work inside Write a review form , because else you will not be able to submit the review :
scrollreview

@vcarciu vcarciu reopened this Feb 9, 2017
@kumar303
Copy link
Contributor Author

kumar303 commented Feb 9, 2017

@vcarciu D'oh. Good catch, thanks. Can you open a new bug for this? That will make it easier to track because #1739 is about to land soon as well (which will remove the title).

@vcarciu
Copy link

vcarciu commented Feb 9, 2017

@kumar303 : logged #1773

@kumar303
Copy link
Contributor Author

kumar303 commented Feb 9, 2017

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants