Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify max characters error message upon addon submit #2295

Closed
Smile4ever opened this issue Apr 21, 2017 · 3 comments
Closed

Clarify max characters error message upon addon submit #2295

Smile4ever opened this issue Apr 21, 2017 · 3 comments

Comments

@Smile4ever
Copy link

@Smile4ever Smile4ever commented Apr 21, 2017

Describe the problem and steps to reproduce it:

An newly submitted addon with supporting i18n names can hit the name limit without a clear message on addons.mozilla.org.

What happened?

The addon name i18n for Dutch is for example "Shop & winkel goedkoop bij Amazon.com zonder extra kosten" (57 characters). The English name is "Shop on Amazon.com without extra costs" (38 characters).

You put in "Shop on Amazon.com without extra costs" as a name (38 characters) and yet is says "Ensure this value has at most 50 characters (it has 57)".

What did you expect to happen?

A message is displayed which shows the name which is too long, instead of the vague message right now.

Anything else we should know?

Screenshot from https://discourse.mozilla-community.org/t/cannot-submit-because-of-the-limitation-for-name/14096/6

@kumar303
Copy link
Contributor

@kumar303 kumar303 commented Apr 21, 2017

Hi, thanks for taking the time to file an issue. This part of the code, while it is "frontend," is actually in https://github.com/mozilla/addons-server so it will be more actionable if you can re-file the issue in that repo.

@tofumatt
Copy link
Contributor

@tofumatt tofumatt commented Apr 21, 2017

I've re-filed it at mozilla/addons-server#5229

@kumar303
Copy link
Contributor

@kumar303 kumar303 commented Apr 21, 2017

Thanks @tofumatt !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.