Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep consistency for nav arrows between search results and collections details pages #3436

Closed
ValentinaPC opened this issue Oct 11, 2017 · 4 comments
Closed

Keep consistency for nav arrows between search results and collections details pages #3436

ValentinaPC opened this issue Oct 11, 2017 · 4 comments
Labels
component:collections component:search contrib:assigned project:desktop_pages state:verified_fixed
Milestone
2017.10.19

Comments

@ValentinaPC
Copy link

Steps to reproduce:

  1. Load a collection details page that contains more than 25 add-ons i.e. https://addons-dev.allizom.org/en-US/firefox/collections/mozilla/privacy/
  2. Observe navigation arrows
  3. Search for something i.e. "test" - https://addons-dev.allizom.org/en-US/firefox/search/?platform=windows&q=test
  4. Observe navigation arrows

Expected results:
Pagination arrows are positioned in the same place.

Actual results:
Pagination arrows position differ.

Notes/Issues:
Verified on AMO-dev FF56(Win 7)
Screenshots:
2017-10-11_1344
@willdurand
Copy link
Member

willdurand commented Oct 11, 2017 •
edited

Haha cool that you have opened this one. I wanted to submit a patch for that today.

Personally I prefer the first screenshot (collections). WDYT? /cc @pwalm

@willdurand willdurand reopened this Oct 11, 2017
@willdurand
Copy link
Member

(ooops wrong button)

@tsl143 tsl143 mentioned this issue Oct 12, 2017
Merged
@tsl143
Copy link
Contributor

tsl143 commented Oct 12, 2017

Ohh, I fixed other way round :/

@willdurand willdurand assigned willdurand and unassigned willdurand Oct 16, 2017
@willdurand willdurand added this to the 2017.10.19 milestone Oct 16, 2017
@ValentinaPC
Copy link
Author

Verified as fixed on AMO-dev FF56(Win 7).
Nav arrows look the same in any pages that require navigation.
Postfix screenshots:
coll
search

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component:collections component:search contrib:assigned project:desktop_pages state:verified_fixed
Projects
None yet
Milestone
2017.10.19
Development

No branches or pull requests
4 participants
@muffinresearch @willdurand @tsl143 @ValentinaPC