New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back the gold stars for rating #3754

Closed
krupa opened this Issue Nov 2, 2017 · 9 comments

Comments

Projects
None yet
6 participants
@krupa

krupa commented Nov 2, 2017

I tried to rate an add-on and didn't realize i had rated the add-on because the stars remain grey, even after rating.

We should consider bringing back the gold stars or at least make the change obvious when users have rated an add-on.

@willdurand

This comment has been minimized.

Member

willdurand commented Nov 2, 2017

cc @pwalm

@grahamperrin

This comment has been minimized.

grahamperrin commented Nov 2, 2017

@krupa what's the address of the page where you first observed the issue? And please, which version of the add-on did you rate?

Cross reference: https://discourse.mozilla.org/t/-/20860/19?u=grahamperrin where four or more issues coincide in a single screenshot.

@ValentinaPC

This comment has been minimized.

ValentinaPC commented Nov 3, 2017

@grahamperrin
The gray rating stars are displayed in all of the new AMO frontend pages.
The rating stars are all the same, not matter of the add-on version.

Please see screenshots:

  1. Homepage - at hover over and add-on
    at_hover
  2. Any add-on details page in review section
    add-on_details
  3. All review page
    all_rev
  4. etc.
@grahamperrin

This comment has been minimized.

grahamperrin commented Nov 4, 2017

… look disabled

Yeah, with respect: grey seems a very weird choice of colour to indicate that a thing has been activated, favoured, starred. Grey star?

I truly thought that the roll-out had not yet 'brought forward' my gold star ratings.

Shades of grey are OK-ish on mobile if we draw a comparison with, say, Play Store on Android but on desktop Firefox:

  • me = sad face

– should that sad face be a shade lighter, or darker, than mid-grey? ;-)

@ValentinaPC

This comment has been minimized.

ValentinaPC commented Nov 6, 2017

@grahamperrin : I was just explaining how things look like now, not expressing a personal opinion.
Jfyi I loved the golden stars, also. :)

@grahamperrin

This comment has been minimized.

grahamperrin commented Nov 8, 2017

Thinking about this daily. Shades of grey certainly work well enough for Google's presentation of stuff in its store(s) but AMO is a very different creature.

https://discourse.mozilla.org/t/-/20860/43?u=grahamperrin includes an embedded YouTube video that coincidentally captured the gold before it disappeared from the new look.

tl;dr IMHO the gold was beautiful.

There may be an argument to have the gold appear only when hovering/pointing in the context of personas (themes/appearance add-ons) – e.g. allow the user to be not distracted from the colours in the mini-previews of themes, where multiple themes are in a listing – but I'll probably respectfully argue for consistent use of gold (never grey) wherever there's a rating.

@pwalm

This comment has been minimized.

Contributor

pwalm commented Nov 16, 2017

Sorry for the delay in my response:
The stars on the site are grey to reduce visual overload on the site. That being said, the only stars that should be the lovely gold colour are the stars you interact with the leave a rating:
screen shot 2017-11-16 at 3 52 59 pm

It comes down to:

  • Yellow = Interactive. Personal rating.
  • Grey = Not interactive. Cumulative rating.
@grahamperrin

This comment has been minimized.

grahamperrin commented Nov 17, 2017

I agree with the wish to not overload things visually, but FWIW I don't buy into the mixed approach to star behaviours.

Another comparison:

2017-11-17 13 12 54 opera add-ons

2017-11-17 13 13 12 enhancer for youtube extension - opera add-ons

2017-11-17 13 13 26 extensions - opera add-ons

It might sound corny but I do 'feel the love' more where I see gold stars from other users.

@pwalm pwalm closed this Dec 4, 2017

@kumar303

This comment has been minimized.

Member

kumar303 commented Dec 4, 2017

I couldn't find an issue for fixing the current stars (maybe I missed it). I filed a new one: #4029

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment