New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncated options from 'Flag' review menu end too abruptly after selection #4359

Closed
AlexandraMoga opened this Issue Feb 9, 2018 · 3 comments

Comments

Projects
None yet
5 participants
@AlexandraMoga

AlexandraMoga commented Feb 9, 2018

STR:

  1. Log into AMO and set your locale to /ru/
  2. Pick a rated add-on to view its details page
  3. Go to the rating section and click on Read all reviews to view all available reviews for this add-on (i.e. https://addons-dev.allizom.org/ru/firefox/addon/awesome-screenshot-plus-/reviews/)
  4. Click on 'Flag' for any of the listed reviews and select the second or the last option from the menu

Actual result:
After selection, the text will end too abruptly (it doesn't seem to have a text-overflow rule applied)

Expected result:
The text for the selected option should end with an 'ellipsis'

Notes:

  • it would also be helpful to show a tooltip for truncated options to give the user the possibility to read the full text
  • reproduced on all AMO servers with FF58, Win10 and Android 7.0

image

@svitlana-galianova

This comment has been minimized.

Contributor

svitlana-galianova commented Apr 5, 2018

Hi,
I believe this issue should be closed now.
I have fixed issue #4318 in Pull Request #4710 and my PR has fixed this issue as well.

screen shot 2018-04-05 at 2 19 42 pm

@tofumatt

This comment has been minimized.

Member

tofumatt commented Apr 5, 2018

@svitlana-galianova Nice job, two issues with one pull request! 🏅 😄

@tofumatt tofumatt closed this Apr 5, 2018

@vcarciu

This comment has been minimized.

vcarciu commented Apr 10, 2018

Verified as fixed :
russian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment