New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The profile picture placeholder from the user info card is too small #4648

Closed
AlexandraMoga opened this Issue Mar 28, 2018 · 6 comments

Comments

Projects
4 participants
@AlexandraMoga

AlexandraMoga commented Mar 28, 2018

Follow up for #4283

Prerequisites: user has not set a profile picture to their account

STR:

  1. Log in to AMO-dev and select 'View profile' from the user menu
  2. Observe the profile image in the user info card

Actual result:
The profile picture placeholder is much smaller than what is depicted in the mocs

Expected result:
The profile picture placeholder has the same dimensions as displayed in the mocs

Notes:

  • reproduced on AMO-dev, with FF59, WIn10x64 and Android 7.0

image

@tofumatt

This comment has been minimized.

Member

tofumatt commented Mar 28, 2018

😱 Oops, thanks for catching this, should be an easy fix.

@tofumatt tofumatt added this to the 2018.04.05 milestone Mar 28, 2018

@svitlana-galianova

This comment has been minimized.

Contributor

svitlana-galianova commented Mar 28, 2018

Hey, I would like to work on this issue

@tofumatt

This comment has been minimized.

Member

tofumatt commented Mar 28, 2018

Hi @svitlana-galianova, thanks for your interest but I'm going to be taking this issue. 😄 You can have a look at our "contrib: good first bugs" issues to find issues to contribute to.

@svitlana-galianova

This comment has been minimized.

Contributor

svitlana-galianova commented Mar 28, 2018

@tofumatt I should have waited for your response...

@tofumatt tofumatt removed their assignment Mar 28, 2018

@tofumatt

This comment has been minimized.

Member

tofumatt commented Mar 28, 2018

It's cool! In the future you should check the "assigned" field in GitHub; if the issue is assigned it's best not to work on it, but I hadn't actually started so it's okay 😄

@tofumatt tofumatt closed this in 7798ccb Mar 31, 2018

@AlexandraMoga

This comment has been minimized.

AlexandraMoga commented Apr 2, 2018

Verified as fixed on AMO-dev, FF59, Win10x64 and Android 7.0

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment