New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "unavailable for your FF version/platform" banner displays the Firefox logo icon instead of an exclamation mark #4851

Closed
AlexandraMoga opened this Issue Apr 19, 2018 · 6 comments

Comments

Projects
None yet
3 participants
@AlexandraMoga

AlexandraMoga commented Apr 19, 2018

STR:

  1. Access AMO and visit the listing page of an add-on that is incompatible with your FF version or platform (see https://addons.allizom.org/en-US/firefox/addon/csp-warning-22-02/)
  2. Observe the red notification banner displayed on the add-on details card

Actual result:
The banner displays a Firefox logo icon instead of an exclamation mark "!"

Expected result:
The message banner should be displaying the exclamation mark "!" icon

Notes:

  • most likely introduced by #4749, which, from my understanding, was intended only for the "download Firefox" message
  • reproduced on all AMO servers, with FF59, Win10x64 and Android 7.0

image

image

image

@bobsilverberg

This comment has been minimized.

Contributor

bobsilverberg commented Apr 19, 2018

If this really is a bug it's probably a P2. @pwalm can you confirm that this should have the exclamation point icon instead of the Firefox icon?

@AlexandraMoga

This comment has been minimized.

AlexandraMoga commented Apr 19, 2018

See #4175 for some background (when photon notifications were implemented)

@bobsilverberg

This comment has been minimized.

Contributor

bobsilverberg commented Apr 19, 2018

That seems pretty definitive, thanks @AlexandraMoga.

@pwalm

This comment has been minimized.

Contributor

pwalm commented Apr 19, 2018

Yep, that's a bug. Should be the exclamation mark @AlexandraMoga mentioned.

@bobsilverberg

This comment has been minimized.

Contributor

bobsilverberg commented Apr 30, 2018

Fixed via #4853

@AlexandraMoga

This comment has been minimized.

AlexandraMoga commented May 2, 2018

Verified as fixed on AMO stage with FF59, Win10x64 and Android 7.0

image
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment