New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RE: [a11y] Links to read reviews are confusing for screen reader/keyboard users #10945
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10945 +/- ##
==========================================
- Coverage 98.39% 98.38% -0.01%
==========================================
Files 258 258
Lines 7538 7556 +18
Branches 1366 1372 +6
==========================================
+ Hits 7417 7434 +17
- Misses 113 114 +1
Partials 8 8
Continue to review full report at Codecov.
|
5fc3666
to
344d290
Compare
Thanks for the feedback, @diox ! The latest pull request removes the template strings and utilizes |
344d290
to
3315bb6
Compare
Thanks again for the feedback, @diox! The latest pull request has |
Thanks for the feedback, @diox! The latest push reflects an updated stylesheet that removes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, thanks @xlisachan !
@xlisachan if you comment in the issue we can assign it to you |
Fixes #8860
This pull request refactors the multiple links per rating by star to a single link (an approach mentioned in #9254).
In addition, it updates the link titles to include the number of reviews per rating by star (e.g., 'Read all 7 five-star reviews'). Conditions were also added in case there is only one or no reviews available (e.g. 'Read the four-star review', 'No three-star reviews yet').
Please review when you have a moment. Thank you!