Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Erroneous trailing quote #2698 #2701

Merged
merged 3 commits into from Jul 7, 2017

Conversation

Projects
None yet
3 participants
@tsl143
Copy link
Contributor

commented Jul 7, 2017

Erroneous trailing quote #2698

@tsl143 tsl143 force-pushed the tsl143:I2698 branch 2 times, most recently from 21a96f6 to 6531c57 Jul 7, 2017

@tsl143 tsl143 force-pushed the tsl143:I2698 branch from 6531c57 to faf433d Jul 7, 2017

@tofumatt
Copy link
Member

left a comment

Thanks! Just a month tweak requested then it's good to merge.

@@ -514,7 +514,7 @@ msgid "No add-ons found"
msgstr ""

#: src/amo/components/SearchContextCard/index.js:45
msgid "%(count)s add-on found\""
msgid "%(count)s add-on found"

This comment has been minimized.

Copy link
@tofumatt

tofumatt Jul 7, 2017

Member

You shouldn't need to modify/commit this file. We'll do that as part of our locale extract/merge. Just changing the source should be fine.

@muffinresearch

This comment has been minimized.

Copy link
Member

commented Jul 7, 2017

Following this landing we might want to consider manually updating the key in the translations so we don't get fuzzy translations OR alternatively it will get fixed up eventually after extraction.

@tofumatt tofumatt merged commit 3de173a into mozilla:master Jul 7, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 95.451%
Details

@tofumatt tofumatt referenced this pull request Jul 7, 2017

Closed

Erroneous trailing quote #2698

@tsl143 tsl143 deleted the tsl143:I2698 branch Jul 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.