New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #4633: changed color of "Download Firefox" message bar #4636

Merged
merged 2 commits into from Mar 26, 2018

Conversation

Projects
None yet
5 participants
@svitlana-galianova
Contributor

svitlana-galianova commented Mar 26, 2018

Hello,
I have changed the color of the "Download Firefox" message bar from the grey to green, as requested in #4633. Here is a screenshot of how the message looks right now:
screen shot 2018-03-25 at 8 34 06 pm

@SeanPrashad

This comment has been minimized.

Contributor

SeanPrashad commented Mar 26, 2018

Good to see you here @svitlana-galianova 😁🖖🏽Before the devs get here, we should fix up that one failing test that Travis is reporting:

Summary of all failing tests
FAIL tests/unit/amo/components/TestAddonCompatibilityError.js
  � /home/travis/build/mozilla/addons-frontend/tests/unit/amo/components/TestAddonCompatibilityError.js › renders a generic notice for non-Firefox browsers

    Expected <Notice> "type" prop values to match but they didn't.
    Expected: �[33mtype�[39m�[90m:�[39m �[33m�[90m"generic"�[33m�[39m
    Actual: �[33mtype�[39m�[90m:�[39m �[33m�[90m"success"�[33m�[39m
      
      at Object.<anonymous> (tests/unit/amo/components/TestAddonCompatibilityError.js:79:74)


Test Suites: 1 failed, 196 passed, 197 total
Tests:       1 failed, 2711 passed, 2712 total
Snapshots:   0 total
Time:        235.125s
Ran all test suites.

With that brand spanking new colour, you'll have to update the old test to reflect it!

@svitlana-galianova

This comment has been minimized.

Contributor

svitlana-galianova commented Mar 26, 2018

Wow! I didn't know I was getting a personal mentor as well! Thanks, @SeanPrashad

@tofumatt

This comment has been minimized.

Member

tofumatt commented Mar 26, 2018

Eventually the new bar should have a button link on the right hand side instead of the inline one, but this covers the original issue and works for me! 😄

Thanks!

@tofumatt tofumatt merged commit 530e8bb into mozilla:master Mar 26, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk No dependency changes
Details
@codecov-io

This comment has been minimized.

codecov-io commented Mar 26, 2018

Codecov Report

Merging #4636 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4636   +/-   ##
=======================================
  Coverage   95.48%   95.48%           
=======================================
  Files         204      204           
  Lines        4738     4738           
  Branches      958      958           
=======================================
  Hits         4524     4524           
  Misses        188      188           
  Partials       26       26
Impacted Files Coverage Δ
...rc/amo/components/AddonCompatibilityError/index.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a442c1...185e345. Read the comment docs.

@caitmuenster

This comment has been minimized.

caitmuenster commented Mar 26, 2018

Thanks so much, @svitlana-galianova! Your contribution has been added to our recognition wiki.

Would you be interested in creating an account on mozillians.org? I'd be happy to vouch for you!

@svitlana-galianova

This comment has been minimized.

Contributor

svitlana-galianova commented Mar 26, 2018

@caitmuenster Thank you! And here is my mozillian account: https://mozillians.org/en-US/u/svitlana.galianova/
@tofumatt If you have an open issue for implementing those changes/are going to create it, please include me there, I would love to help!

@svitlana-galianova svitlana-galianova deleted the svitlana-galianova:fixing4633 branch Mar 26, 2018

@caitmuenster

This comment has been minimized.

caitmuenster commented Mar 26, 2018

Yay! You're vouched. :) Welcome onboard! I look forward to seeing you around the project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment