New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #4626: added spacing between 'featured' badge and theme preview in Theme details page #4707

Merged
merged 2 commits into from Apr 2, 2018

Conversation

Projects
None yet
2 participants
@svitlana-galianova
Contributor

svitlana-galianova commented Apr 2, 2018

I have added spacing between 'featured' badge and theme preview in Theme details page.
I have modified left margins only by 6px and 12px based on the screen size. #4626

Before:
screen shot 2018-04-02 at 9 54 22 am

After:
screen shot 2018-04-02 at 9 53 24 am

@tofumatt

This looks good and I think is enough of an improvement to land, but the styles need tweaking for RTL locales. After that it's good to go 😄

@@ -12,9 +12,13 @@
}
.AddonBadges .Badge {
margin: 0 0 0 6px;

This comment has been minimized.

@tofumatt

tofumatt Apr 2, 2018

Member

This won't work when the language is RTL, so you'll want to use our RTL-aware mixin instead: @include margin(0 0 0 6px);.

Though in this case if you're only setting left margin you can just use @include margin-start(6px);

This comment has been minimized.

@svitlana-galianova

svitlana-galianova Apr 2, 2018

Contributor

Thanks for the suggestion, I have just updated it

@tofumatt tofumatt merged commit 4e33142 into mozilla:master Apr 2, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk No dependency changes
Details

@svitlana-galianova svitlana-galianova deleted the svitlana-galianova:fixing#4626 branch Apr 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment