New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #4633: changed the icon on firefox compatibility error #4749

Merged
merged 2 commits into from Apr 5, 2018

Conversation

Projects
None yet
2 participants
@svitlana-galianova
Contributor

svitlana-galianova commented Apr 5, 2018

#4633: I have change the icon of the error message from check mark to Firefox one.

screen shot 2018-04-05 at 3 00 22 pm

@tofumatt tofumatt self-requested a review Apr 5, 2018

@tofumatt

I'm surprised this isn't using our Icon component from src/ui/components/Icon/... but since it isn't I think this is the right approach.

Thanks for getting to this, I know UX really wanted it to be the Firefox icon 😄

@tofumatt

This comment has been minimized.

Member

tofumatt commented Apr 5, 2018

To be clear: the failing build here is because of #4747.

@tofumatt tofumatt merged commit 4d00766 into mozilla:master Apr 5, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
security/snyk No new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment