Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tooltips to Extension Workshop and DevHub header links #7860

Merged
merged 1 commit into from Apr 9, 2019

Conversation

Projects
None yet
4 participants
@ithompson4
Copy link
Contributor

commented Apr 9, 2019

Fixes #7831

Add tooltips to the Extension Workshop and DevHub header links:

  • Extension Workshop: "Learn how to create extensions and themes"
  • Developer Hub: "Submit and manage extensions and themes"

tooltipAddons

@codecov-io

This comment has been minimized.

Copy link

commented Apr 9, 2019

Codecov Report

Merging #7860 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7860   +/-   ##
=======================================
  Coverage   98.04%   98.04%           
=======================================
  Files         259      259           
  Lines        7101     7101           
  Branches     1312     1312           
=======================================
  Hits         6962     6962           
  Misses        125      125           
  Partials       14       14
Impacted Files Coverage Δ
src/amo/components/Header/index.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce28695...0550ba4. Read the comment docs.

@ithompson4 ithompson4 changed the title Added tooltips to Extension Workshop and DevHub header links, issue #… Added tooltips to Extension Workshop and DevHub header links Apr 9, 2019

@willdurand willdurand self-assigned this Apr 9, 2019

@willdurand willdurand merged commit 1c2e067 into mozilla:master Apr 9, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - package.json (Add-ons Team) No manifest changes detected
@willdurand

This comment has been minimized.

Copy link
Member

commented Apr 9, 2019

Thanks @ithompson4 🎉

@caitmuenster

This comment has been minimized.

Copy link

commented Apr 9, 2019

Woo, thanks for the patch @ithompson4! 🎉 Your contribution has been added to our recognition wiki.

Would you be interested in creating an account on mozillians.org? I'd be happy to vouch for you!

@ithompson4

This comment has been minimized.

Copy link
Contributor Author

commented Apr 9, 2019

Hello @caitmuenster. Yes, please, I would like to get the account on mozillians.org. Thank you.

@caitmuenster

This comment has been minimized.

Copy link

commented Apr 10, 2019

Awesome, @ithompson4! When you have a minute, head over to https://mozillians.org and create an account, then ping me with the URL and I'll vouch for you. 😎

@ithompson4

This comment has been minimized.

Copy link
Contributor Author

commented Apr 11, 2019

@caitmuenster

This comment has been minimized.

Copy link

commented Apr 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.