New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Illegal values in optional_permissions should be accepted #1788

Open
piroor opened this Issue Jan 25, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@piroor

piroor commented Jan 25, 2018

Describe the problem and steps to reproduce it:

Firefox now accepts illegal values in optional_permissions (after the Bug 1350759: Warn but accept illegal values in optional_permissions) but the linter still blocks any unknown permission names. Thus I cannot release my addon including new permission tabHide in optional permissions which is implemented at Firefox 59.

Steps to reproduce:

  1. Create an addon including tabHide in its optional_permissions.
  2. Upload it to AMO.

What happened?

I got 4 errors and couldn't release the version:

"/optional_permissions/2" should be equal to one of the allowed values

エラー: Your JSON file could not be parsed.
"/optional_permissions/2" should match some schema in anyOf

エラー: Your JSON file could not be parsed.
"/optional_permissions/2" should match pattern "^(https?|wss?|file|ftp|\*)://(\*|\*\.[^*/]+|[^*/]+)/.*$"

エラー: Your JSON file could not be parsed.
"/optional_permissions/2" should match pattern "^file:///.*$"

エラー: Your JSON file could not be parsed.

What did you expect to happen?

A new permission tabHide is warned but not reported as an error.

Anything else we should know?

(Please include screenshots and any relevant files.)

This is the file I uploaded.
treestyletab-we.xpi.zip

piroor added a commit to piroor/treestyletab that referenced this issue Jan 26, 2018

Deactivate "hide inactive tabs" feature.
Due to mozilla/addons-linter#1788 we cannot release a version with "tabHide" permission.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment