Import Firefox 56 schemas #1449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some quick testing shows that permissions are validated fine. I'm not sure what's causing it to format like that though. |
|
@mstriemer see the lint config PR there is a broken test relating to schema permissions. #1451 (comment) |
|
I filed #1459 but I don't think that's blocking this. It fails the same way on this branch and on master. |
|
These changes are up for review again in #1461. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looked through it and it looks okay. The first update to manifest.json doesn't look quite right. Going to open the PR and see if it has any side effects.
Fixes #1346.