From 2d3f1626d2b58455afe14feb043f958623842ce7 Mon Sep 17 00:00:00 2001 From: Mathieu Agopian Date: Tue, 16 Jun 2015 11:16:33 +0200 Subject: [PATCH] fix regression: updateURL should be allowed for unlisted addons (bug 1175060) --- static/js/common/upload-addon.js | 4 ++-- static/js/zamboni/devhub.js | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/static/js/common/upload-addon.js b/static/js/common/upload-addon.js index b4978a89945..0c746c58d7b 100644 --- a/static/js/common/upload-addon.js +++ b/static/js/common/upload-addon.js @@ -265,8 +265,8 @@ // If the addon is detected as beta, automatically check // the "beta" input, but only if the addon is listed. var $new_form = $('.new-addon-file'); - var isUnlisted = $('#id_is_unlisted').is(':checked') || !$new_form.data('addon-is-listed') - var $beta = $('#id_beta'); + var isUnlisted = ($('#id_is_unlisted').length && $('#id_is_unlisted').is(':checked')) || !$new_form.data('addon-is-listed') + var $beta = $('#id_beta'); if (results.beta && !isUnlisted) { $beta.prop('checked', true); $('.beta-status').show(); diff --git a/static/js/zamboni/devhub.js b/static/js/zamboni/devhub.js index 256a52209b0..4a2e55c9669 100644 --- a/static/js/zamboni/devhub.js +++ b/static/js/zamboni/devhub.js @@ -97,7 +97,7 @@ $(document).ready(function() { var $isManualReview = $('#manual-review'); var $submitAddonProgress = $('.submit-addon-progress'); function updateListedStatus() { - if (!$isUnlisted.is(':checked') || $new_form.data('addon-is-listed')) { // It's a listed add-on. + if (($isUnlisted.length && !$isUnlisted.is(':checked')) || $new_form.data('addon-is-listed')) { // It's a listed add-on. $uploadAddon.attr('data-upload-url', $uploadAddon.attr('data-upload-url-listed')); $betaWarningLabel.hide(); $isSideloadLabel.hide();