Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve dehub navigation bar (bug 750904) #12

Merged

Conversation

magopian
Copy link
Contributor

(moved from zamboni/pull/1752)

https://bugzilla.mozilla.org/show_bug.cgi?id=750904

What that does:

  • change the red title (h2) to display add-on name
  • modify navigation panel to only bold current link
  • create the new "status box" at the top
    • add version information (current/latest version, position in the review queue)
    • add tooltip on status
    • add specific information when a version is being reviewed/rejected

devhub status box and nav panel

@vinyll
Copy link
Contributor

vinyll commented Mar 12, 2014

Any reason to change id="enable-addon" to class="enable-addon"?

@magopian
Copy link
Contributor Author

There's now sometimes several links on the same page to do the same thing. As we can't have multiple times the same id, I opted to use classes (and modified the javascript that hijacks the link clicks to display the pop-ins).

@diox
Copy link
Member

diox commented Mar 13, 2014

@cvan is this good to go now?

@magopian
Copy link
Contributor Author

@kmaglione it seems you're really comfortable with the different statuses and the review flow for addons, would you mind giving a review on this PR? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants