Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SameSite=Lax on frontend auth token cookie #14376

Closed
diox opened this issue May 25, 2020 · 2 comments · Fixed by #14377
Closed

Use SameSite=Lax on frontend auth token cookie #14376

diox opened this issue May 25, 2020 · 2 comments · Fixed by #14377
Assignees
@diox
Labels
component:code_quality state:verified_fixed
Milestone
2020.05.28

Comments

@diox
Copy link
Member

diox commented May 25, 2020

While our sessionid cookie has SameSite=Lax, currently our frontend_auth_token cookie (that is not used directly by the API, but to pass the token to the frontend) doesn't. Let's unify that.
@diox diox added this to the 2020.05.28 milestone May 25, 2020
@diox diox self-assigned this May 25, 2020
@diox diox mentioned this issue May 25, 2020
Merged
@diox
Copy link
Member Author

diox commented May 25, 2020

QA: make sure logging in and out still works (and that you're correctly logged in and out of frontend, devhub & code-manager at the same time).

@AlexandraMoga
Copy link

This issue is verified fixed on -dev with the following scenarios:

  • log in/log out in frontend => user log in/log out state is correctly propagated in devhub, rev tools and code-manager
  • log in/log out in devhub=> user log in/log out state is correctly propagated in frontend, rev tools and code-manager
  • log in/log out in rev tools=> user log in/log out state is correctly propagated in devhub, frontend and code-manager
  • log in/log out in code-manager=> user log in/log out state is correctly propagated in devhub, rev tools and frontend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diox diox

Labels
component:code_quality state:verified_fixed
Projects
None yet
Milestone
2020.05.28
Development

Successfully merging a pull request may close this issue.

Pass SameSite=Lax to frontend auth token cookie diox/olympia
2 participants
@diox @AlexandraMoga