Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless {% with %} tags in admin tools #20215

Closed
diox opened this issue Jan 23, 2023 · 1 comment · Fixed by #20399
Closed

Remove useless {% with %} tags in admin tools #20215

diox opened this issue Jan 23, 2023 · 1 comment · Fixed by #20399
Assignees
Labels
component:admin_tools component:code_quality contrib:maybe_good_first_bug priority:p4 Lower priority backlog. These are potentially good candidates for contributions. qa:not_needed
Milestone

Comments

@diox
Copy link
Member

diox commented Jan 23, 2023

#20208 removes translations in reviewer/admin tools. A few {% blocktrans %} were changed to {% with %} in admin templates to keep the diff simpler, but they serve no purpose and could be removed by changing the variable name(s) used inside the block to use the actual name and not the alias provided by the {% with %}

┆Issue is synchronized with this Jira Task

@diox diox added component:code_quality component:admin_tools priority:p3 This priority level reflects our backlog. labels Jan 23, 2023
@diox diox added priority:p4 Lower priority backlog. These are potentially good candidates for contributions. contrib:maybe_good_first_bug and removed priority:p3 This priority level reflects our backlog. labels Jan 23, 2023
@predystopic-dev
Copy link
Contributor

Can you assign this to me? I asked about it in matrix chat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:admin_tools component:code_quality contrib:maybe_good_first_bug priority:p4 Lower priority backlog. These are potentially good candidates for contributions. qa:not_needed
Projects
None yet
2 participants