Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify max characters error message upon addon submit #5229

Open
tofumatt opened this issue Apr 21, 2017 · 7 comments
Open

Clarify max characters error message upon addon submit #5229

tofumatt opened this issue Apr 21, 2017 · 7 comments

Comments

@tofumatt
Copy link
Contributor

@tofumatt tofumatt commented Apr 21, 2017

Originally submitted to addons-frontend


Describe the problem and steps to reproduce it:

An newly submitted addon with supporting i18n names can hit the name limit without a clear message on addons.mozilla.org.

What happened?

The addon name i18n for Dutch is for example "Shop & winkel goedkoop bij Amazon.com zonder extra kosten" (57 characters). The English name is "Shop on Amazon.com without extra costs" (38 characters).

You put in "Shop on Amazon.com without extra costs" as a name (38 characters) and yet is says "Ensure this value has at most 50 characters (it has 57)".

What did you expect to happen?

A message is displayed which shows the name which is too long, instead of the vague message right now.

Anything else we should know?

Screenshot from https://discourse.mozilla-community.org/t/cannot-submit-because-of-the-limitation-for-name/14096/6

@EnTeQuAk
Copy link
Contributor

@EnTeQuAk EnTeQuAk commented Apr 16, 2018

This will certainly go away once we improved our metadata handling #7825 and only allow changing this via updating things in the manifest.

I'll leave this open though since a proper error message has to be implemented there too.

@stale
Copy link

@stale stale bot commented Sep 6, 2019

This issue has been automatically marked as stale because it has not had recent activity. If you think this bug should stay open, please comment on the issue with further details. Thank you for your contributions.

@stale stale bot added the state: stale label Sep 6, 2019
@Smile4ever
Copy link

@Smile4ever Smile4ever commented Sep 6, 2019

Keep it open

@stale stale bot removed the state: stale label Sep 6, 2019
@stale
Copy link

@stale stale bot commented Mar 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. If you think this bug should stay open, please comment on the issue with further details. Thank you for your contributions.

@stale stale bot added the state: stale label Mar 4, 2020
@Smile4ever
Copy link

@Smile4ever Smile4ever commented Mar 4, 2020

Has this been addressed?

@stale stale bot removed the state: stale label Mar 4, 2020
@stale
Copy link

@stale stale bot commented Sep 1, 2020

This issue has been automatically marked as stale because it has not had recent activity. If you think this bug should stay open, please comment on the issue with further details. Thank you for your contributions.

@stale stale bot added the state: stale label Sep 1, 2020
@Smile4ever
Copy link

@Smile4ever Smile4ever commented Sep 1, 2020

Keep it open and look at #7825

@stale stale bot removed the state: stale label Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.