New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify max characters error message upon addon submit #5229

Open
tofumatt opened this Issue Apr 21, 2017 · 1 comment

Comments

Projects
None yet
5 participants
@tofumatt
Member

tofumatt commented Apr 21, 2017

Originally submitted to addons-frontend


Describe the problem and steps to reproduce it:

An newly submitted addon with supporting i18n names can hit the name limit without a clear message on addons.mozilla.org.

What happened?

The addon name i18n for Dutch is for example "Shop & winkel goedkoop bij Amazon.com zonder extra kosten" (57 characters). The English name is "Shop on Amazon.com without extra costs" (38 characters).

You put in "Shop on Amazon.com without extra costs" as a name (38 characters) and yet is says "Ensure this value has at most 50 characters (it has 57)".

What did you expect to happen?

A message is displayed which shows the name which is too long, instead of the vague message right now.

Anything else we should know?

Screenshot from https://discourse.mozilla-community.org/t/cannot-submit-because-of-the-limitation-for-name/14096/6

@EnTeQuAk

This comment has been minimized.

Show comment
Hide comment
@EnTeQuAk

EnTeQuAk Apr 16, 2018

Member

This will certainly go away once we improved our metadata handling #7825 and only allow changing this via updating things in the manifest.

I'll leave this open though since a proper error message has to be implemented there too.

Member

EnTeQuAk commented Apr 16, 2018

This will certainly go away once we improved our metadata handling #7825 and only allow changing this via updating things in the manifest.

I'll leave this open though since a proper error message has to be implemented there too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment