Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter by compatibility within collection API #6279

Open
grahamperrin opened this Issue Aug 30, 2017 · 3 comments

Comments

Projects
None yet
5 participants
@grahamperrin
Copy link

grahamperrin commented Aug 30, 2017

project: firefox 57 compatibility

Enhancement request

At #4974 (comment) (2017-06-03) under Add label to listing pages to highlight WebExtensions · Issue #4974 · mozilla/addons-server, @erosman wrote:

Collections could also benefit from the tag

Additionally, it should be possible to:

  • exclude legacy items

– in other words, filter by compatibility.

If not filter, then please at least allow readers to sort by compatibility.

For now, in the absence of tags

I use multiprocess-compatible User Agent Overrider to quickly set or unset an appropriate string.

Examples

https://addons.mozilla.org/en-GB/firefox/collections/Firebreathing/h/?sort=added (a Hidden Gems! collection), without then with an override:

2017-08-30 01 36 15 hidden gems collections add-ons for firefox

Mozilla/5.0 (X11; FreeBSD amd64; rv:57.0) Gecko/20100101 Firefox/57.0

2017-08-30 01 34 49 hidden gems collections add-ons for firefox

A more popular collection (6,284 followers), sorted by popularity, exemplifying the current likelihood of promotion of legacy items, without attention to compatibility –

2017-08-30 01 59 14 optimized firefox collections add-ons for firefox

– then with:

2017-08-30 01 58 05 optimized firefox collections add-ons for firefox

I wondered whether the FreeBSD/Linux aspect of my general.useragent.override was skewing things, so I switched to:

Windows / Firefox 57: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:57.0) Gecko/20100101 Firefox/57.0

– then browsed all nine pages of that popular collection. Not one green display of compatibility </cough> ;-)

@eviljeff

This comment has been minimized.

Copy link
Member

eviljeff commented Sep 6, 2017

The collections feature is being rewritten and will be relaunched later this year with a different (more focused) feature set, so we both have to consider the current collections, and the rewrite.
@jvillalobos
Is this kind of sorting/filtering necessary to add to the current collections views? And should they be added to the API (and frontend) The API currently supports some sorting options, but doesn't support any filtering.

@jvillalobos

This comment has been minimized.

Copy link
Member

jvillalobos commented Sep 6, 2017

I think that filtering out incompatible add-ons by default in collections is a good idea. I wouldn't put any effort for this in the old front-end, though.

@eviljeff

This comment has been minimized.

Copy link
Member

eviljeff commented Sep 7, 2017

On the API side we can add support for platform and application parameters to be passed, and that will filter.

It will be up to the front-end to pass these parameters, and handle the UI, as we can't filter by default unless we know what platform/application the user has. @jvillalobos can you log the addons-frontend issue - there may be UX requirements, etc.

@eviljeff eviljeff changed the title Filter and/or sort by compatibility within a collection Filter by compatibility within collection API Sep 7, 2017

@diox diox added priority: p4 and removed priority: p3 labels Sep 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.